Custom Query (193 matches)


Show under each result:

Results (4 - 6 of 193)

1 2 3 4 5 6 7 8 9 10 11 12
Ticket Resolution Summary Owner Reporter
#394 fixed check_data() may use uninitialized variable nobody peter

The routine check_data() suppresses cautions about md5sum mismatches when the NO TIME command is in effect. Hence it reads the variable prt.lgPrintTime. This variable is first set in the routine InitDefaultsPreparse(). The problem is that by then some data files have already been read and check_data() will have read the "uninitialized" version of prt.lgPrintTime (actually since the data is global, it will have been set to zero / false by default which is the wrong initialization).

There are two solutions.

1) give t_prt a ctor that sets lgPrintTime. This guarantees consistent behavior when the NO TIME command is not in effect, but not when the NO TIME command is used. The latter is a problem because some files are read before the parsing starts, leading to inconsistent behavior of check_data() before and after parsing.

2) revert the change to check_data() and give a caution despite the NO TIME command. This way check_data() no longer needs to access prt.lgPrintTime. However, this will lead to more frequent breaking of the repeatability tests whenever a datafile on a release branch has been updated without updating the md5sum file.

I am not sure yet which is the better solution...

#393 fixed Blnd equivalents of 6lev lines in c13 are missing nobody peter

In c17 the 6lev lines were removed. We also made sure that enough levels were included in the stout O I model to capture the Ly beta fluorescence. However, currently this mechanism is broken (see #78).

The 6lev lines gave predictions for full multiplets, while stout resolves all the multiplets into individual lines. For backward compatibility we should add Blnd entries for multiplets that correspond to the old 6lev entries in c13.

#391 fixed do not use C as a comment character peter Gary J. Ferland

see the extensive discussion on both user groups, and Peter recommended solution

1 2 3 4 5 6 7 8 9 10 11 12
Note: See TracQuery for help on using queries.