Ticket #118 (closed defect - convergence: fixed)
wild oscillations in ionization and temperature on second iteration, does not abbort as dr -> 0
|Reported by:||gary||Owned by:||nobody|
The HII region model reported by Valentina has major problems with the trunk, although it runs fine with c08. There are two separate problems.
The major problem is a very large osciallation in the ionization and resulting temperature on the second iteration. This sets in by zone 3 or 4, and the H0 fraction oscillates between ~1e-7 and ~1e-13 in adjacent zones.
In response to this oscillation the code makes the zones thinner. It very quickly reaches the smallest possible zone thickness where the code used to abort. This abort feature appears to have been removed from radius_next by Ryan in R3621 - as a result the simulation continues with the zone thickness of 1e-36 cm until the limit of 1400 zones is hit. This takes more than an hour on this mac. Had the abort been left in the sim would have failed in ten minutes rather than more than an hours.
We need to get the abort feature back in. Why was this removed? is it a simple matter of reverting R3621?
Next problem - the oscillation. Have not debugged it yet but this has all the hallmarks of the classic Lya oscillation. There were dampers in the code to prevent this, and I know that some were removed.