Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#124 closed defect - etc (fixed)

double counted lines from lindst

Reported by: Gary J. Ferland Owned by: Gary J. Ferland
Priority: major Milestone: c13 release
Component: infrastructure Version: trunk
Keywords: double counted info lines Cc:

Description

Ryan points out that we double count some lines in the outward beam in calls to lindst. his email:


Seems like most of them actually involve a PutExtra? followed by PutLine?.

But the ones that concern me most are the three OII lines starting around line 883 of prt_lines_lv1_li_ne.cpp. These are have corresponding lindst calls (in addition to linadd calls), and while these lindst calls are "information" lines, they also have "true" for the sixth lindst parameter (lgOutToo). That means the line gets added to the emitted spectrum.

I wonder if we should assert that lgOutToo is false if chInfo is "i".


I agree we should add the assert. He wrote test code and found the following info lines in the outward beam. Most are indeed double counting. I need to work through this list and make sure all are bogus.

Here are (some of) the "info" lines that also have lgOutToo set to true. This is just one sim. There is a lot of overlap in other sims, but it's not easy to come up with a unique list.

Ryan

e-e+ 0.024270 TOTL 9850.000000 pump 3920.000000 TOTL 6580.000000 C 3 1907.000000 13C3 1910.000000 TOTL 3467.000000 TOTr 5199.000000 chem 5199.000000 H CT 5199.000000 pump 5199.000000 TOTL 5199.000000 TOTL 10403.000000 N 2 5755.000000 pump 3311.000000 pump 3840.000000 pump 3609.000000 pump 4640.000000 pump 5010.000000 TOTL 5679.000000 N3cn 4640.000000 N3cn 4634.000000 N3cn 4642.000000 pump 3120.000000 pump 3300.000000 pump 3762.000000 O 2r 4651.000000 TOTL 4341.000000 TOTL 3736.000000 TOTL 4363.000000 diel 1260.000000 diel 1909.000000 Si 3 1883.000000 S II 6731.000000 S II 6716.000000 S II 4070.000000 S II 4078.000000 Cl 3 5538.000000 Cl 3 5518.000000 Cl 3 3354.000000 Cl 3 3344.000000 Cl 3 8504.000000 Cl 3 8436.000000 Cl 3 8552.000000 Cl 3 8483.000000 Ca2K 3934.000000 Ca2H 3969.000000 Ca2X 8498.000000 Ca2Y 8542.000000 Ca2Z 8662.000000 CaF1 7291.000000 CaF2 7324.000000 Fe 4 3096.000000 Fe 4 2836.000000 Fe 4 2829.000000 Fe 4 2567.000000 Fe 4 27740.000000 Fe 4 27140.000000 Fe 4 27160.000000 Fe 4 28060.000000 Fe 4 28650.000000 Fe 4 28360.000000 Fe14 5303.000000

Change History (2)

comment:1 Changed 8 years ago by Gary J. Ferland

Resolution: fixed
Status: newclosed

comment:2 Changed 5 years ago by Ryan Porter

Milestone: C10 releasec13 release

Milestone C10 release deleted

Note: See TracTickets for help on using tickets.