Opened 7 years ago

#163 new physics

fine/coarse interaction

Reported by: Ryan Porter Owned by: nobody
Priority: major Milestone:
Component: radiative transfer Version: trunk
Keywords: Cc:

Description

The attached patchfile pertains to changes I proposed in the use of rfield.trans_coef_zone[] and rfield.trans_coef_total[], which I believe are incorrectly applied and only at the output stage.

Related to this, the FractionThisLine? code in pressure.h is also fundamentally flawed. The attached input deck (based on a model from Nick) begins strong oscillations around zone 168 (of the second iteration, but the root problem can be seen at the same point of the first iteration) due to the NII 1084A wings initially overlapping with HeII 1085, and then not overlapping at all (as temperature decreases). This cause a huge (incorrect) increase in HeII radiation pressure, which is the root of the oscillations.

Gary and Robin have described these and related issues in draft manuscripts elsewhere.

Attachments (2)

patchfile (4.9 KB) - added by Ryan Porter 7 years ago.
patchfile replacing rfield.trans_coef_total[] at output with rfield.trans_coef_zone[] at intermediate stages (and related changes)
nick.in (765 bytes) - added by Ryan Porter 7 years ago.
model from Nick with major oscillations

Download all attachments as: .zip

Change History (2)

Changed 7 years ago by Ryan Porter

Attachment: patchfile added

patchfile replacing rfield.trans_coef_total[] at output with rfield.trans_coef_zone[] at intermediate stages (and related changes)

Changed 7 years ago by Ryan Porter

Attachment: nick.in added

model from Nick with major oscillations

Note: See TracTickets for help on using tickets.