Opened 6 years ago

Closed 6 years ago

#206 closed defect - failed assert (fixed)

assert thrown when chianti data files with more than one Aul for a transition used

Reported by: Gary J. Ferland Owned by: nobody
Priority: major Milestone: C13 branch
Component: atomic/molecular data base Version: trunk
Keywords: Cc:

Description

r5209 - trunk

Chianti has some transitions with more than one set of transition probabilities. They sometimes keep various moments of the transition probability separate. This causes the assert at atmdat_chianti.cpp:464 to throw. This assert was commented out in this rev.

The chianti model that caused this was H I which we do not want to do with Chianti. In species.cpp a test was added to stop if one of the iso sequences is included in the chianti masterlist.

The assert in atmdat_chianti will not throw if we only use the limited range of chianti we are now working with. But it will throw if, in the future, chianti keep more than one component of the transition, as they did do for H I two photon.

The assert in atmdat_chianti needs to be made more robust. we could make the rule that multiple Aul are not allowed and change the assert to a print with an explanation when the data are parsed.

Change History (5)

comment:1 Changed 6 years ago by Gary J. Ferland

to see the problem try this

uncomment line 12, o 8, in CloudyChiantiAll?.ini in data / chianti / masterlist

run this test set chianti on

as changed the comment about h-like iso cannot be done in chianti will print and the code will stop. uncomment the assert - it will trip on that assert due to the two photon double counting in chianti before it detects the use a an h-like species

comment:2 in reply to:  1 Changed 6 years ago by Gary J. Ferland

if you uncomment o 8 in CloudyChianitiAll?.ini you need to run chiani as follows

test set chianti on "CloudyChiantiAll?.ini"

comment:3 Changed 6 years ago by Gary J. Ferland

test
set chianti on "CloudyChiantiAll?.ini" 

comment:4 Changed 6 years ago by Gary J. Ferland

r5218 changes commented out assert to print followed by exit

comment:5 Changed 6 years ago by Gary J. Ferland

Resolution: fixed
Status: newclosed

see ticket #208 for a better description of this problem.

Note: See TracTickets for help on using tickets.