Opened 4 years ago

Closed 3 years ago

#281 closed defect - code aborts (fixed)

Constant temperature without radiation FPEs

Reported by: mchatzikos Owned by: nobody
Priority: blocker Milestone: C17_branch
Component: fault - segfault, fpe, etc Version: trunk
Keywords: Cc:

Description

We now allow for sims without a specified radiation field, yet the following sim fails at init_sim_postparse.cpp:115 because radius.Radius = 0:

constant temp 5e7 linear
hden 7 log
set dr 0
stop zone 1

Using 'coronal equilibrium' instead works because the command also sets the radius.

Change History (6)

comment:1 Changed 3 years ago by Gary J. Ferland

Priority: majorcritical

comment:2 Changed 3 years ago by Gary J. Ferland

Priority: criticalblocker

comment:3 Changed 3 years ago by rjrw

Patching over the immediate failure (r9860), this still fails at cont_setintensity.cpp:1392

comment:4 Changed 3 years ago by rjrw

Type: defect - FPEdefect - code aborts

No more FPEs after r9862, but still:

  radius_next finds insane drNext: 0.00e+00
 all drs follow:
 0.00e+00 sphericity
 1.00e+00 capped to old DR in first zone
 1.00e+00 sdrmax
 4.00e+00 DRMAX
 5.61e+16 optical depth to electron scattering
 1.00e+30 A_V to go
 3.40e+36 change in big H2 Solomon rate line opt depth
 3.40e+36 change in big H2 Solomon rate line opt depth
 [Stop in radius_next at radius_next.cpp:1046, something went wrong]

comment:5 Changed 3 years ago by Gary J. Ferland

this sim should fall into our "intensity case" so an inner radius should not be needed.

is there a problem determining whether intensity or luminosity case is intended? How is the logic leading up to this problem any different from our intensity case with photon?

comment:6 Changed 3 years ago by mchatzikos

Resolution: fixed
Status: newclosed

Radius sanity check has been moved from ParseCoronal?() to ParseCommands?() to enforce setting a default radius when using either of the 'coronal' and 'constant temperature' commands without radiation. The test suite runs clean with these changes.

See r9957.

Note: See TracTickets for help on using tickets.