Opened 3 years ago

Closed 2 years ago

#303 closed defect - wrong answer (fixed)

update small H2 cooling to Glover & Abel

Reported by: Gary J. Ferland Owned by: nobody
Priority: blocker Milestone: C17_branch
Component: thermal convergence Version: trunk
Keywords: Cc:

Description

The small H2 (used in most cases) uses expressions from Lepp & Shull which overestimate the H2 cooling by nearly 1 dex. Phillip recommends using expressions from Glover & Abel.

The attached copy of cool_eval.cpp has the coefficients from their paper pasted at line 263 where the expressions need to be evaluated.

Attachments (1)

cool_eval.cpp (32.9 KB) - added by Gary J. Ferland 3 years ago.
code with coefficients pasted into location where needed

Download all attachments as: .zip

Change History (3)

Changed 3 years ago by Gary J. Ferland

Attachment: cool_eval.cpp added

code with coefficients pasted into location where needed

comment:1 Changed 3 years ago by peter

Component: etcthermal convergence

comment:2 Changed 2 years ago by Gary J. Ferland

Resolution: fixed
Status: newclosed

Marios did this

Note: See TracTickets for help on using tickets.