Ticket #36 (closed defect - etc: fixed)

Opened 6 years ago

Last modified 5 years ago

grid command picks up wrong keyword

Reported by: peter Owned by: Ryan Porter
Priority: minor Milestone:
Component: input parser Version:
Keywords: Cc:

Description

When the attached case is run with r1505 of the trunk, it will crash on a failed assert. This case is identical to the standard test suite case ism_grid.in, except that some (seemingly innocent) comments have been added to the grid command. However, the command line parser picks up the keyword "intensity" in those comments, leading to completely wrong behavior. The keyword "intensity" is specific to the optimize command and should be ignored in the grid command.

In my view it would be better to generate separate routines ParseOptimize and ParseGrid since the command line structure is quite different for the two commands (the optimize command has far more keywords than the grid command). I believe that would lead to clearer code that is easier to maintain.

Attachments

ism_grid.in (2.0 kB) - added by peter 6 years ago.
test case that causes the crash

Change History

Changed 6 years ago by peter

test case that causes the crash

Changed 5 years ago by rporter

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.