Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#378 closed defect - wrong answer (fixed)

md5 sums do not appear to work

Reported by: Gary J. Ferland Owned by: nobody
Priority: major Milestone: C17_branch
Component: etc Version: trunk
Keywords: Cc:

Description

I have done two tests to check the behavior of the md5 checksums. First was a checkout of the tag for c17 rc1, on cloud9. Marios and I did several changes to the data files and no comment was generated. I also tried this on a Mac with same result. We edited the stout masterlist and changed one of the stout atomic data files.

Change History (4)

comment:1 Changed 11 months ago by peter

The checksum tests are only executed when either lgRelease or lgReleaseBranch is true. So the md5 checksum test is executed on c17_branch and the upcoming c17.00 release, but not c17 rc1 since the latter has neither lgRelease or lgReleaseBranch set.

The test is only carried out for the masterlist files. Regular data files are currently not checked. This would create an additional overhead on reading the data files that would likely be noticeable.

comment:2 Changed 11 months ago by peter

In r11504 and r11505 the code has been changed to set lgReleaseBranch to true for beta releases. This implies that the md5sum checks are now carried out for release candidates as well.

comment:3 Changed 11 months ago by Gary J. Ferland

Resolution: fixed
Status: newclosed

Turns out that the md5 sums were not tested in release candidates. Peter modified the code to do this in the future.

comment:4 Changed 11 months ago by peter

Checking all data files was committed in r11510 and r11511.

Note: See TracTickets for help on using tickets.