Opened 7 years ago

Last modified 7 years ago

#225 new defect - failed assert

error in input script results in obscure crash

Reported by: peter Owned by: nobody
Priority: minor Milestone: C13 branch
Component: input parser Version: c10.00
Keywords: Cc:


The attached script was posted by one of our users on the Yahoo site.

Both with c08.01 and c10.00 this script very quickly fails due to a failed assert. The reason is that the user includes both a "dlaw table depth" command and a "constant density" command.

 An assert has been thrown, this is bad.
 Failed: fabs( dense.gas_phase[ipHYDROGEN] - dense.den0 )/ dense.gas_phase[ipHYDROGEN]<1e-4
 It happened in the file mole_h_drive.cpp at line number 228
 This is iteration 1, nzone 0, fzone 0.00, lgSearch=T.

It is clear that the user made an error, but the failure mode is very unhelpful. Can we change the parser such that it would detect this inappropriate combination of commands, and possibly other incompatible commands? Simply checking for the combination of commands listed above seems fragile. Can we come up with a better solution?

Attachments (1) (1.5 KB) - added by peter 7 years ago.
input script submitted by Henry L. Bradsher

Download all attachments as: .zip

Change History (2)

Changed 7 years ago by peter

Attachment: added

input script submitted by Henry L. Bradsher

comment:1 Changed 7 years ago by peter

Version: c10_branchc10.00
Note: See TracTickets for help on using tickets.